ivshmem: Fix 64 bit memory bar configuration
commitbe4e0d737527d8670dc271712faae0de6a181b4e
authorZhuang Yanying <ann.zhuangyanying@huawei.com>
Thu, 17 Nov 2016 12:31:03 +0000 (17 20:31 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 18 Nov 2016 15:29:34 +0000 (18 17:29 +0200)
tree5dbc85c11f98abcf3e4742c1977a67cc0ee0d890
parent83d768b5640946b7da55ce8335509df297e2c7cd
ivshmem: Fix 64 bit memory bar configuration

Device ivshmem property use64=0 is designed to make the device
expose a 32 bit shared memory BAR instead of 64 bit one.  The
default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit
BAR.  A 32 bit BAR can support only up to 1 GiB of shared memory.

This worked as designed until commit 5400c02 accidentally flipped
its sense: since then, we misinterpret use64=0 as use64=1 and vice
versa.  Worse, the default got flipped as well.  Devices
ivshmem-plain and ivshmem-doorbell are not affected.

Fix by restoring the test of IVShmemState member not_legacy_32bit
that got messed up in commit 5400c02.  Also update its
initialization for devices ivhsmem-plain and ivshmem-doorbell.
Without that, they'd regress to 32 bit BARs.

Cc: qemu-stable@nongnu.org
Signed-off-by: Zhuang Yanying <ann.zhuangyanying@huawei.com>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
hw/misc/ivshmem.c