| commit | be4d026f645eb31078e08d431c93a898b895024e | |
| author | Greg Kurz <groug@kaod.org> | |
| Sat, 7 Apr 2018 14:43:46 +0000 (7 16:43 +0200) | ||
| committer | Cornelia Huck <cohuck@redhat.com> | |
| Mon, 9 Apr 2018 11:50:31 +0000 (9 13:50 +0200) | ||
| tree | 46d85c2e6148ebc63f78c62a7d57b9df5a2cc95a | treesnapshot (tar.gz zip) |
| parent | c607bb8f8a6287704fdf06c78ee24d7443a6a8af | commitdiff |
vfio-ccw: fix memory leaks in vfio_ccw_realize()
If the subchannel is already attached or if vfio_get_device() fails, the
code jumps to the 'out_device_err' label and doesn't free the string it
has just allocated.
The code should be reworked so that vcdev->vdev.name only gets set when
the device has been attached, and freed when it is about to be detached.
This could be achieved with the addition of a vfio_ccw_get_device()
function that would be the counterpart of vfio_put_device(). But this is
a more elaborate cleanup that should be done in a follow-up. For now,
let's just add calls to g_free() on the buggy error paths.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <152311222681.203086.8874800175539040298.stgit@bahia>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
If the subchannel is already attached or if vfio_get_device() fails, the
code jumps to the 'out_device_err' label and doesn't free the string it
has just allocated.
The code should be reworked so that vcdev->vdev.name only gets set when
the device has been attached, and freed when it is about to be detached.
This could be achieved with the addition of a vfio_ccw_get_device()
function that would be the counterpart of vfio_put_device(). But this is
a more elaborate cleanup that should be done in a follow-up. For now,
let's just add calls to g_free() on the buggy error paths.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <152311222681.203086.8874800175539040298.stgit@bahia>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| hw/vfio/ccw.c | diffblobblamehistory |