| commit | bd5d2353aa69e68e45d8a89787bab17c155e9e24 | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Sat, 4 Feb 2017 23:08:35 +0000 (4 23:08 +0000) | ||
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | |
| Sun, 26 Feb 2017 14:39:29 +0000 (26 15:39 +0100) | ||
| tree | 3de67a859ac82b7da07bb17e50dec1d15177d89b | treesnapshot (tar.gz zip) |
| parent | 70f2e64e4dde21ba8b2e8d3fd682533c89a53487 | commitdiff |
slirp: tcp_listen(): Don't try to close() an fd we never opened
Coverity points out (CID 1005725) that an error-exit path in tcp_listen()
will try to close(s) even if the reason it got there was that the
qemu_socket() failed and s was never opened. Not only that, this isn't even
the right function to use, because we need closesocket() to do the right
thing on Windows. Change to using the right function and only calling it if
needed.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Coverity points out (CID 1005725) that an error-exit path in tcp_listen()
will try to close(s) even if the reason it got there was that the
qemu_socket() failed and s was never opened. Not only that, this isn't even
the right function to use, because we need closesocket() to do the right
thing on Windows. Change to using the right function and only calling it if
needed.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
| slirp/socket.c | diffblobblamehistory |