| commit | ba306c7a55a2fcdb51c279612f0f8fbd9a24a7ba | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Mon, 7 Dec 2015 15:55:10 +0000 (7 16:55 +0100) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Mon, 7 Dec 2015 17:13:10 +0000 (7 17:13 +0000) | ||
| tree | fe0ad33cdcc7533b7876866a6ecd246af31fd28d | treesnapshot (tar.gz zip) |
| parent | 79f21707898aaeebb070cb7301846562b77e6fbf | commitdiff |
sd: Mark brittle abuse of blk_attach_dev() FIXME
blk_attach_dev() fails here only when we're working for device
"sdhci-pci" (which already attached the backend), and then we don't
want to attach a second time. If we ever create another failure mode,
we're setting up ourselves to using the same backend from multiple
frontends, which is likely to end in tears. Can't clean this up this
close to the release, so mark it FIXME.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1449503710-3707-3-git-send-email-armbru@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
blk_attach_dev() fails here only when we're working for device
"sdhci-pci" (which already attached the backend), and then we don't
want to attach a second time. If we ever create another failure mode,
we're setting up ourselves to using the same backend from multiple
frontends, which is likely to end in tears. Can't clean this up this
close to the release, so mark it FIXME.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1449503710-3707-3-git-send-email-armbru@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| hw/sd/sd.c | diffblobblamehistory |