| commit | b690d679c1ca65d71b0544a2331d50e9f0f95116 | |
| author | Peter Lieven <pl@kamp.de> | |
| Thu, 8 May 2014 16:03:15 +0000 (8 18:03 +0200) | ||
| committer | Luiz Capitulino <lcapitulino@redhat.com> | |
| Fri, 9 May 2014 13:11:32 +0000 (9 09:11 -0400) | ||
| tree | fb328bf796d9b14b650517e8a42894f782228e39 | treesnapshot (tar.gz zip) |
| parent | cc1626556d264c867a07ebe8672fa06b208e209a | commitdiff |
Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()"
This reverts commit 25a7017555f1b4aeb543b5d323ff4afb8f9c5437.
Turns out the argument *can* be null: QEMU now segfaults if it
receives an invalid parameter via a qmp command instead of throwing an
error.
For example:
{ "execute": "blockdev-add",
"arguments": { "options" : { "driver": "invalid-driver" } } }
CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This reverts commit 25a7017555f1b4aeb543b5d323ff4afb8f9c5437.
Turns out the argument *can* be null: QEMU now segfaults if it
receives an invalid parameter via a qmp command instead of throwing an
error.
For example:
{ "execute": "blockdev-add",
"arguments": { "options" : { "driver": "invalid-driver" } } }
CC: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
| qapi/qapi-dealloc-visitor.c | diffblobblamehistory |