| commit | b5806108d20fc32b4692e721d8bd6376f4ca4a69 | |
| author | Alberto Garcia <berto@igalia.com> | |
| Wed, 13 Sep 2017 08:28:17 +0000 (13 11:28 +0300) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Tue, 26 Sep 2017 12:46:23 +0000 (26 14:46 +0200) | ||
| tree | 85e7f935c7dfe158516c34b04bfc57923d146275 | treesnapshot (tar.gz zip) |
| parent | 93e53fb6952c85ef54b209c92358963fb66d0fa2 | commitdiff |
throttle: Assert that bkt->max is valid in throttle_compute_wait()
If bkt->max == 0 and bkt->burst_length > 1 then we could have a
division by 0 in throttle_do_compute_wait(). That configuration is
however not permitted and is already detected by throttle_is_valid(),
but let's assert it in throttle_compute_wait() to make it explicit.
Found by Coverity (CID: 1381016).
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
If bkt->max == 0 and bkt->burst_length > 1 then we could have a
division by 0 in throttle_do_compute_wait(). That configuration is
however not permitted and is already detected by throttle_is_valid(),
but let's assert it in throttle_compute_wait() to make it explicit.
Found by Coverity (CID: 1381016).
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| util/throttle.c | diffblobblamehistory |