| commit | b503de619ed462cd433187db60719f98fab470c2 | |
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | |
| Sat, 24 Aug 2019 10:07:40 +0000 (24 13:07 +0300) | ||
| committer | Max Reitz <mreitz@redhat.com> | |
| Tue, 3 Sep 2019 12:55:35 +0000 (3 14:55 +0200) | ||
| tree | 1e3e3d77ef3f25eb29372f85396cf2f66d6bb8ff | treesnapshot (tar.gz zip) |
| parent | 4d731510d34f280ed45a6de621d016f67a49ea48 | commitdiff |
block: fix permission update in bdrv_replace_node
It's wrong to OR shared permissions. It may lead to crash on further
permission updates.
Also, no needs to consider previously calculated permissions, as at
this point we already bind all new parents and bdrv_get_cumulative_perm
result is enough. So fix the bug by just set permissions by
bdrv_get_cumulative_perm result.
Bug was introduced in long ago 234ac1a9025, in 2.9.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190824100740.61635-1-vsementsov@virtuozzo.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
It's wrong to OR shared permissions. It may lead to crash on further
permission updates.
Also, no needs to consider previously calculated permissions, as at
this point we already bind all new parents and bdrv_get_cumulative_perm
result is enough. So fix the bug by just set permissions by
bdrv_get_cumulative_perm result.
Bug was introduced in long ago 234ac1a9025, in 2.9.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190824100740.61635-1-vsementsov@virtuozzo.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
| block.c | diffblobblamehistory |