hw/virtio/vhost-vsock: Fix missing ERRP_GUARD() for error_prepend()
commitb403c8d5e07aead1a5834d21d4c6eeabd2669bd7
authorZhao Liu <zhao1.liu@intel.com>
Mon, 11 Mar 2024 03:38:18 +0000 (11 11:38 +0800)
committerThomas Huth <thuth@redhat.com>
Tue, 12 Mar 2024 10:45:45 +0000 (12 11:45 +0100)
treedfa9b4206bcb4267040950975bed22701c4d84bf
parent498696ef7646b7ae9938336f34a5a97a44dd3af7
hw/virtio/vhost-vsock: Fix missing ERRP_GUARD() for error_prepend()

As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():

* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*   error_append_hint(), because that doesn't work with &error_fatal.
* ERRP_GUARD() lifts these restrictions.
*
* To use ERRP_GUARD(), add it right at the beginning of the function.
* @errp can then be used without worrying about the argument being
* NULL or &error_fatal.

ERRP_GUARD() could avoid the case when @errp is &error_fatal, the user
can't see this additional information, because exit() happens in
error_setg earlier than information is added [1].

The vhost_vsock_device_realize() passes @errp to error_prepend(), and as
a VirtioDeviceClass.realize method, its @errp is from
DeviceClass.realize so that there is no guarantee that the @errp won't
point to @error_fatal.

To avoid the issue like [1] said, add missing ERRP_GUARD() at the
beginning of this function.

[1]: Issue description in the commit message of commit ae7c80a7bd73
     ("error: New macro ERRP_GUARD()").

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Message-ID: <20240311033822.3142585-26-zhao1.liu@linux.intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
hw/virtio/vhost-vsock.c