block: drop bs->job
commitb23c580c946644b906af36e3f903b9fedd6ccd61
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Thu, 6 Jun 2019 15:41:32 +0000 (6 18:41 +0300)
committerKevin Wolf <kwolf@redhat.com>
Tue, 18 Jun 2019 14:41:10 +0000 (18 16:41 +0200)
treefd1da098448077b498db94f12df9a1d3aa411b32
parent8164102ffe02dfc6478c0b3f8ffce29705a9a53b
block: drop bs->job

Drop remaining users of bs->job:
1. assertions actually duplicated by assert(!bs->refcnt)
2. trace-point seems not enough reason to change stream_start to return
   BlockJob pointer
3. Restricting creation of two jobs based on same bs is bad idea, as
   3.1 Some jobs creates filters to be their main node, so, this check
   don't actually prevent creating second job on same real node (which
   will create another filter node) (but I hope it is restricted by
   other mechanisms)
   3.2 Even without bs->job we have two systems of permissions:
   op-blockers and BLK_PERM
   3.3 We may want to run several jobs on one node one day

And finally, drop bs->job pointer itself. Hurrah!

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/trace-events
blockdev.c
blockjob.c
include/block/block_int.h
tests/test-blockjob.c