| commit | af7084e72b66e4c3008f7a70d5f2a06e11af7fbe | |
| author | Shivaprasad G Bhat <sbhat@linux.ibm.com> | |
| Thu, 27 Feb 2020 13:42:49 +0000 (27 07:42 -0600) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 16 Mar 2020 22:41:14 +0000 (17 09:41 +1100) | ||
| tree | bed3977bc613478d513fcc085d2087e0df4133cd | treesnapshot (tar.gz zip) |
| parent | 22062e54bb68f5ced71fbdb3f5f2bedb09a8e8c1 | commitdiff |
spapr: Fix Coverity warning while validating nvdimm options
Fixes Coverity issue,
CID 1419883: Error handling issues (CHECKED_RETURN)
Calling "qemu_uuid_parse" without checking return value
nvdimm_set_uuid() already verifies if the user provided uuid is valid or
not. So, need to check for the validity during pre-plug validation again.
As this a false positive in this case, assert if not valid to be safe.
Also, error_abort if QOM accessor encounters error while fetching the uuid
property.
Reported-by: Coverity (CID 1419883)
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Message-Id: <158281096564.89540.4507375445765515529.stgit@lep8c.aus.stglabs.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Fixes Coverity issue,
CID 1419883: Error handling issues (CHECKED_RETURN)
Calling "qemu_uuid_parse" without checking return value
nvdimm_set_uuid() already verifies if the user provided uuid is valid or
not. So, need to check for the validity during pre-plug validation again.
As this a false positive in this case, assert if not valid to be safe.
Also, error_abort if QOM accessor encounters error while fetching the uuid
property.
Reported-by: Coverity (CID 1419883)
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Message-Id: <158281096564.89540.4507375445765515529.stgit@lep8c.aus.stglabs.ibm.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/ppc/spapr_nvdimm.c | diffblobblamehistory |