qmp: Don't use error_is_set() to suppress additional errors
commitab31979a7e835832605f8425d0eaa5c74d1e6375
authorMarkus Armbruster <armbru@redhat.com>
Fri, 2 May 2014 11:26:42 +0000 (2 13:26 +0200)
committerLuiz Capitulino <lcapitulino@redhat.com>
Fri, 9 May 2014 13:11:32 +0000 (9 09:11 -0400)
treea6c1fad34ebab86f90803ce8c57e539637a37734
parent66ef8bd9c16b547c985cbe7468dcf60280c993eb
qmp: Don't use error_is_set() to suppress additional errors

Using error_is_set(errp) that way can sweep programming errors under
the carpet when we get called incorrectly with an error set.

encrypted_bdrv_it() does it, because there's no way to make
bdrv_iterate() break its loop.  Actually safe, because qmp_cont()
clears the error before the loop.  Clean it up anyway: replace
bdrv_iterate() by bdrv_next(), break the loop on error.

Replace both occurrences, for consistency.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
qmp.c