| commit | aad10040d411d21542dc9ae58a2854c89ccedd78 | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 26 Jun 2018 13:39:18 +0000 (26 15:39 +0200) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Thu, 28 Jun 2018 17:05:35 +0000 (28 19:05 +0200) | ||
| tree | 22f095148df48091b0b7633a5a9884028804ec29 | treesnapshot (tar.gz zip) |
| parent | 86933b4e7879e427e03365bf352c0964640cb37b | commitdiff |
pr-manager-helper: avoid SIGSEGV when writing to the socket fail
When writing to the qemu-pr-helper socket failed, the persistent
reservation manager was correctly disconnecting the socket, but it
did not clear pr_mgr->ioc. So the rest of the code did not know
that the socket had been disconnected, accessed pr_mgr->ioc and
happily caused a crash.
To reproduce, it is enough to stop qemu-pr-helper between QEMU
startup and executing e.g. sg_persist -k /dev/sdb.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
When writing to the qemu-pr-helper socket failed, the persistent
reservation manager was correctly disconnecting the socket, but it
did not clear pr_mgr->ioc. So the rest of the code did not know
that the socket had been disconnected, accessed pr_mgr->ioc and
happily caused a crash.
To reproduce, it is enough to stop qemu-pr-helper between QEMU
startup and executing e.g. sg_persist -k /dev/sdb.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| scsi/pr-manager-helper.c | diffblobblamehistory |