linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS
commita932eec49d9ec106c7952314ad1adc28f0986076
authorAlex Bennée <alex.bennee@linaro.org>
Thu, 21 May 2020 13:57:48 +0000 (21 14:57 +0100)
committerThomas Huth <thuth@redhat.com>
Thu, 28 May 2020 05:58:36 +0000 (28 07:58 +0200)
tree6985ef826665ac2fa61bac7dc58663699790dcb5
parent06539ebc76b8625587aa78d646a9d8d5fddf84f3
linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS

Newer clangs rightly spot that you can never exceed the full address
space of 64 bit hosts with:

  linux-user/elfload.c:2076:41: error: result of comparison 'unsigned
  long' > 18446744073709551615 is always false
  [-Werror,-Wtautological-type-limit-compare]
  4685         if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) {
  4686             ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~
  4687 1 error generated.

So lets limit the check to 32 bit hosts only.

Fixes: ee94743034bf
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200525131823.715-8-thuth@redhat.com>
[thuth: Use HOST_LONG_BITS < TARGET_ABI_BITS instead of HOST_LONG_BITS == 32]
Signed-off-by: Thomas Huth <thuth@redhat.com>
linux-user/elfload.c