| commit | a8efa60633575a2ee4dbf807a71cb44d44b0e0f8 | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Wed, 14 Nov 2018 11:36:57 +0000 (14 12:36 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 27 Nov 2018 14:06:14 +0000 (27 15:06 +0100) | ||
| tree | aa3206f7576f8a2ffd25431bdbf92ee70b65b788 | treesnapshot (tar.gz zip) |
| parent | d98f26073bebddcd3da0ba1b86c3a34e840c0fb8 | commitdiff |
cpus: run work items for all vCPUs if single-threaded
This avoids the following I/O thread deadlock:
1) the I/O thread calls run_on_cpu for CPU 3 from a timer. single_tcg_halt_cond
is signaled
2) CPU 1 is running and exits. It finds no work item and enters CPU 2
3) because the I/O thread is stuck in run_on_cpu, the round-robin kick
timer never triggers, and CPU 3 never runs the work item
4) run_on_cpu never completes
Reviewed-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This avoids the following I/O thread deadlock:
1) the I/O thread calls run_on_cpu for CPU 3 from a timer. single_tcg_halt_cond
is signaled
2) CPU 1 is running and exits. It finds no work item and enters CPU 2
3) because the I/O thread is stuck in run_on_cpu, the round-robin kick
timer never triggers, and CPU 3 never runs the work item
4) run_on_cpu never completes
Reviewed-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| cpus.c | diffblobblamehistory |