io/channel-websock: handle continuous reads without any data
commita46ded1de5cf0edd6c780e071ddafb92601070b5
authorEdgar Kaziakhmedov <edgar.kaziakhmedov@virtuozzo.com>
Wed, 10 Jan 2018 15:39:24 +0000 (10 18:39 +0300)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 15 Feb 2018 16:54:57 +0000 (15 16:54 +0000)
tree7f538816906bd367ebd670932587d311ca573174
parent28bb0a59f84c11c42117a7009646508256ed4475
io/channel-websock: handle continuous reads without any data

According to the current implementation of websocket protocol in QEMU,
qio_channel_websock_handshake_io tries to read handshake from the
channel to start communication over socket. But this approach
doesn't cover scenario when socket was closed while handshaking.
Therefore, if G_IO_IN is caught and qio_channel_read returns zero,
error has to be set and connection has to be done.

Such behaviour causes 100% CPU load in main QEMU loop, because main loop
poll continues to receive and handle G_IO_IN events from websocket.

Step to reproduce 100% CPU load:
1) start qemu with the simplest configuration
$ qemu -vnc [::1]:1,websocket=7500
2) open any vnc listener (which doesn't follow websocket
protocol)
$ vncviewer :7500
3) kill listener
4) qemu main thread eats 100% CPU

Signed-off-by: Edgar Kaziakhmedov <edgar.kaziakhmedov@virtuozzo.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
io/channel-websock.c