| commit | a30cf8760f4a59797fc060c3c5a13b7749551d0c | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 26 Aug 2014 10:16:08 +0000 (26 12:16 +0200) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Fri, 19 Sep 2014 08:50:07 +0000 (19 10:50 +0200) | ||
| tree | d58e6aa83608c9f98f04f87c251d959147ce891c | treesnapshot (tar.gz zip) |
| parent | 4df7961faaa317d57e873ecdec58422d3f979336 | commitdiff |
serial: check if backed by a physical serial port at realize time
Right now, s->poll_msl may linger at "0" value for an arbitrarily long
time, until serial_update_msl is called for the first time. This is
unnecessary, and will lead to the s->poll_msl field being unnecessarily
migrated.
We can call serial_update_msl immediately at realize time (via
serial_reset) and be done with it. The memory-mapped UART was already
doing that, but not the ISA and PCI variants.
Regarding the delta bits, be consistent with what serial_reset does when
the serial port is not backed by a physical serial port, and always clear
them at reset time.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Right now, s->poll_msl may linger at "0" value for an arbitrarily long
time, until serial_update_msl is called for the first time. This is
unnecessary, and will lead to the s->poll_msl field being unnecessarily
migrated.
We can call serial_update_msl immediately at realize time (via
serial_reset) and be done with it. The memory-mapped UART was already
doing that, but not the ISA and PCI variants.
Regarding the delta bits, be consistent with what serial_reset does when
the serial port is not backed by a physical serial port, and always clear
them at reset time.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/char/serial.c | diffblobblamehistory |