| commit | a2f31f180499593b5edb8ac5ab8ac1b92f0abcd4 | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Wed, 4 Nov 2015 13:48:47 +0000 (4 14:48 +0100) | ||
| committer | Michael Tokarev <mjt@tls.msk.ru> | |
| Fri, 6 Nov 2015 12:42:38 +0000 (6 15:42 +0300) | ||
| tree | 176fdc1f2a9b6726ecffd8d6c22753914e8aa51d | treesnapshot (tar.gz zip) |
| parent | 3ede8f699645f4ca7cdbc40d8139e5a0275b4805 | commitdiff |
qemu-sockets: do not test path with access() before unlinking
Using access() is a time-of-check/time-of-use race condition. It is
okay to use them to provide better error messages, but that is pretty
much it.
This is not one such case; on the other hand, access() *will* skip
unlink() for a non-existent path, so ignore ENOENT return values from
the unlink() system call.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Using access() is a time-of-check/time-of-use race condition. It is
okay to use them to provide better error messages, but that is pretty
much it.
This is not one such case; on the other hand, access() *will* skip
unlink() for a non-existent path, so ignore ENOENT return values from
the unlink() system call.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| util/qemu-sockets.c | diffblobblamehistory |