| commit | a1a6bbde4f6a29368f8f605cea2e73630ec1bc7c | |
| author | Greg Kurz <groug@kaod.org> | |
| Mon, 11 Sep 2017 22:04:40 +0000 (12 00:04 +0200) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Fri, 15 Sep 2017 00:29:48 +0000 (15 10:29 +1000) | ||
| tree | 3df3df454f3c0aab4b8e0b7dca9439ff3a003016 | treesnapshot (tar.gz zip) |
| parent | e100161b69f8cf56dae866912dfffe7dcd7140af | commitdiff |
xics: fix several error leaks
If object_property_get_link() fails then it allocates an error, which
must be freed before returning. The error_get_pretty() function is
merely an accessor to the error message and doesn't free anything.
The error.h header indicates how to do it right:
* Pass an existing error to the caller with the message modified:
* error_propagate(errp, err);
* error_prepend(errp, "Could not frobnicate '%s': ", name);
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
If object_property_get_link() fails then it allocates an error, which
must be freed before returning. The error_get_pretty() function is
merely an accessor to the error message and doesn't free anything.
The error.h header indicates how to do it right:
* Pass an existing error to the caller with the message modified:
* error_propagate(errp, err);
* error_prepend(errp, "Could not frobnicate '%s': ", name);
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/intc/xics.c | diffblobblamehistory |