| commit | a18dc3a14d8455c0b7673f9c3b6cdc4f10a7dade | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Thu, 17 Dec 2020 16:19:57 +0000 (17 17:19 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 18 Dec 2020 11:43:14 +0000 (18 12:43 +0100) | ||
| tree | 5c277d6d25cad2b807d6b339504791e4547c72a7 | treesnapshot (tar.gz zip) |
| parent | b0ce8cb0e8470b37963d1db7e4baca9c3647b0a1 | commitdiff |
block/vpc: Don't abuse the footer buffer for dynamic header
create_dynamic_disk() takes a buffer holding the footer as first
argument. It writes out the footer (512 bytes), then reuses the
buffer to initialize and write out the dynamic header (1024 bytes).
Works, because the caller passes a buffer that is large enough for
both purposes. I hate that.
Use a separate buffer for the dynamic header, and adjust the caller's
buffer.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201217162003.1102738-4-armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
create_dynamic_disk() takes a buffer holding the footer as first
argument. It writes out the footer (512 bytes), then reuses the
buffer to initialize and write out the dynamic header (1024 bytes).
Works, because the caller passes a buffer that is large enough for
both purposes. I hate that.
Use a separate buffer for the dynamic header, and adjust the caller's
buffer.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201217162003.1102738-4-armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| block/vpc.c | diffblobblamehistory |