| commit | a13f20422dc657719c3fa335788300c7ccf464ee | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Tue, 5 May 2020 15:29:19 +0000 (5 17:29 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 15 May 2020 05:07:58 +0000 (15 07:07 +0200) | ||
| tree | d0e83a1e23a15e7c43d9d7399d6562f7fe801b4c | treesnapshot (tar.gz zip) |
| parent | e508430619b3b26112117b6e06ebc5f8f1d54aed | commitdiff |
e1000: Don't run e1000_instance_init() twice
QOM object initialization runs .instance_init() for the type and all
its supertypes; see object_init_with_type().
Both TYPE_E1000_BASE and its concrete subtypes set .instance_init() to
e1000_instance_init(). For the concrete subtypes, it duly gets run
twice. The second run fails, but the error gets ignored (a later
commit will change that).
Remove it from the subtypes.
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-12-armbru@redhat.com>
QOM object initialization runs .instance_init() for the type and all
its supertypes; see object_init_with_type().
Both TYPE_E1000_BASE and its concrete subtypes set .instance_init() to
e1000_instance_init(). For the concrete subtypes, it duly gets run
twice. The second run fails, but the error gets ignored (a later
commit will change that).
Remove it from the subtypes.
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-12-armbru@redhat.com>
| hw/net/e1000.c | diffblobblamehistory |