pcnet: force the buffer access to be in bounds during tx
commit9f7c594c006289ad41169b854d70f5da6e400a2a
authorPetr Matousek <pmatouse@redhat.com>
Sun, 24 May 2015 08:53:44 +0000 (24 10:53 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Wed, 10 Jun 2015 14:03:02 +0000 (10 15:03 +0100)
treec0ec35dc415f0ae1f0306b1dbc21b0d8668ba849
parentb0411142f482df92717f8b4a3b746081a62b724f
pcnet: force the buffer access to be in bounds during tx

4096 is the maximum length per TMD and it is also currently the size of
the relay buffer pcnet driver uses for sending the packet data to QEMU
for further processing. With packet spanning multiple TMDs it can
happen that the overall packet size will be bigger than sizeof(buffer),
which results in memory corruption.

Fix this by only allowing to queue maximum sizeof(buffer) bytes.

This is CVE-2015-3209.

[Fixed 3-space indentation to QEMU's 4-space coding standard.
--Stefan]

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Matt Tait <matttait@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/net/pcnet.c