| commit | 9e8e8c48653471fa5fed447e388fdef57d4f6998 | |
| author | Michael S. Tsirkin <mst@redhat.com> | |
| Thu, 11 Sep 2014 15:42:02 +0000 (11 18:42 +0300) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Thu, 18 Sep 2014 18:51:24 +0000 (18 21:51 +0300) | ||
| tree | aac52d5fb33bd891d608f4cecd80bc2f1cede1cc | treesnapshot (tar.gz zip) |
| parent | 131c5221fe25a9547c4a388a3d26ff7fd14843e5 | commitdiff |
Revert "virtio: don't call device on !vm_running"
This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8.
virtio: don't call device on !vm_running
It turns out that virtio net assumes that vm_running
is updated before device status callback in many places,
so this change leads to asserts.
Previous commit fixes the root issue that motivated
a1bc7b827e422e1ff065640d8ec5347c4aadfcd8 differently,
so there's no longer a need for this change.
In the future, we might be able to drop checking vm_running
completely, and check vm state directly.
Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Cc: qemu-stable@nongnu.org
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This reverts commit a1bc7b827e422e1ff065640d8ec5347c4aadfcd8.
virtio: don't call device on !vm_running
It turns out that virtio net assumes that vm_running
is updated before device status callback in many places,
so this change leads to asserts.
Previous commit fixes the root issue that motivated
a1bc7b827e422e1ff065640d8ec5347c4aadfcd8 differently,
so there's no longer a need for this change.
In the future, we might be able to drop checking vm_running
completely, and check vm state directly.
Reported-by: Dietmar Maurer <dietmar@proxmox.com>
Cc: qemu-stable@nongnu.org
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| hw/virtio/virtio.c | diffblobblamehistory |