| commit | 9bada8971173345ceb37ed1a47b00a01a4dd48cf | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Wed, 25 Nov 2015 21:23:32 +0000 (25 22:23 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Thu, 26 Nov 2015 09:07:07 +0000 (26 10:07 +0100) | ||
| tree | aa81d4f867c5eb59e4af390ef0c9d8da8f4c2131 | treesnapshot (tar.gz zip) |
| parent | 95385fe9ace7db156b924da6b6f5c9082b68ba68 | commitdiff |
qjson: surprise, allocating 6 QObjects per token is expensive
Replace the contents of the tokens GQueue with a simple struct. This cuts
the amount of memory allocated by tests/check-qjson from ~500MB to ~20MB,
and the execution time from 600ms to 80ms on my laptop. Still a lot (some
could be saved by using an intrusive list, such as QSIMPLEQ, instead of
the GQueue), but the savings are already massive and the right thing to
do would probably be to get rid of json-streamer completely.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1448300659-23559-5-git-send-email-pbonzini@redhat.com>
[Straightforwardly rebased on my patches]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Replace the contents of the tokens GQueue with a simple struct. This cuts
the amount of memory allocated by tests/check-qjson from ~500MB to ~20MB,
and the execution time from 600ms to 80ms on my laptop. Still a lot (some
could be saved by using an intrusive list, such as QSIMPLEQ, instead of
the GQueue), but the savings are already massive and the right thing to
do would probably be to get rid of json-streamer completely.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1448300659-23559-5-git-send-email-pbonzini@redhat.com>
[Straightforwardly rebased on my patches]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
| include/qapi/qmp/json-streamer.h | diffblobblamehistory | |
| qobject/json-parser.c | diffblobblamehistory | |
| qobject/json-streamer.c | diffblobblamehistory |