spapr, xics, xive: Match signatures for XICS and XIVE KVM connect routines
commit98a39a7927b510fcdd29f8237b67368a66121c84
authorDavid Gibson <david@gibson.dropbear.id.au>
Thu, 26 Sep 2019 13:23:51 +0000 (26 23:23 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 23 Oct 2019 22:36:55 +0000 (24 09:36 +1100)
tree83774e26daadc7c42eca1020deb91e72539649ba
parent05289273c06de4bc6ece85a8bf672e588e34f36b
spapr, xics, xive: Match signatures for XICS and XIVE KVM connect routines

Both XICS and XIVE have routines to connect and disconnect KVM with
similar but not identical signatures.  This adjusts them to match
exactly, which will be useful for further cleanups later.

While we're there, we add an explicit return value to the connect path
to streamline error reporting in the callers.  We remove error
reporting the disconnect path.  In the XICS case this wasn't used at
all.  In the XIVE case the only error case was if the KVM device was
set up, but KVM didn't have the capability to do so which is pretty
obviously impossible.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
hw/intc/spapr_xive_kvm.c
hw/intc/xics_kvm.c
hw/ppc/spapr_irq.c
include/hw/ppc/spapr_xive.h
include/hw/ppc/xics_spapr.h