gdbstub: revert to previous set_reg behaviour
commit94b2a62bb65b80760bcc59737bec908c9175abf4
authorAlex Bennée <alex.bennee@linaro.org>
Fri, 5 Jul 2019 13:23:07 +0000 (5 14:23 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Wed, 10 Jul 2019 09:54:46 +0000 (10 10:54 +0100)
tree6823a757c0c4c472a71874fd7327417be32df418
parent42a0959648080874119f0430ceddcebfe3faaa28
gdbstub: revert to previous set_reg behaviour

The refactoring of handle_set_reg missed the fact we previously had
responded with an empty packet when we were not using XML based
protocols. This broke the fallback behaviour for architectures that
don't have registers defined in QEMU's gdb-xml directory.

Revert to the previous behaviour and clean up the commentary for what
is going on.

Fixes: 62b3320bddd
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Cc: Jon Doron <arilou@gmail.com>
gdbstub.c