| commit | 9280eb34deb032d7c86275a92651ae63cc5418d5 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Thu, 17 Dec 2015 16:35:13 +0000 (17 17:35 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Wed, 13 Jan 2016 10:58:58 +0000 (13 11:58 +0100) | ||
| tree | 54488387d0ac7e01c94df5bbc92a6e17b3174e92 | treesnapshot (tar.gz zip) |
| parent | 5a8de107e3496855147e823de32ff70cada725d1 | commitdiff |
raven: Mark use of hw_error() in realize() FIXME
Device realize() methods aren't supposed to call hw_error(), they
should set an error and fail cleanly. Blindly doing that would be
easy enough, but then realize() would fail without undoing its side
effects. Just mark it FIXME for now.
Cc: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-ppc@nongnu.org
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1450370121-5768-6-git-send-email-armbru@redhat.com>
Device realize() methods aren't supposed to call hw_error(), they
should set an error and fail cleanly. Blindly doing that would be
easy enough, but then realize() would fail without undoing its side
effects. Just mark it FIXME for now.
Cc: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-ppc@nongnu.org
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1450370121-5768-6-git-send-email-armbru@redhat.com>
| hw/pci-host/prep.c | diffblobblamehistory |