| commit | 927411fa42c5fcf16ed0fcc0447d5ee8c83b22ca | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 20 Jan 2015 10:07:09 +0000 (20 11:07 +0100) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Mon, 26 Jan 2015 11:27:05 +0000 (26 12:27 +0100) | ||
| tree | 849eff7d539176c3b0bb86d5689526252d625072 | treesnapshot (tar.gz zip) |
| parent | 874b1cfad51e325d535f99261f91c92df444c18c | commitdiff |
apic: do not dereference pointer before it is checked for NULL
Right now you only get to apic_init_reset if you have an APIC
(do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and
that only happens in hw/intc/apic.c). However, this is wrong
because for example a port 92 or keyboard controller reset is
really an INIT, and that can happen also with no APIC. So
keep the check and fix the error that Coverity reported.
Reported-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Right now you only get to apic_init_reset if you have an APIC
(do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and
that only happens in hw/intc/apic.c). However, this is wrong
because for example a port 92 or keyboard controller reset is
really an INIT, and that can happen also with no APIC. So
keep the check and fix the error that Coverity reported.
Reported-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/intc/apic_common.c | diffblobblamehistory |