block: Give always priority to unused entries in the qcow2 L2 cache
commit8e8cb375e0964b4ed099cb8563029028db26a834
authorAlberto Garcia <berto@igalia.com>
Thu, 5 Feb 2015 12:55:31 +0000 (5 14:55 +0200)
committerKevin Wolf <kwolf@redhat.com>
Fri, 6 Feb 2015 16:24:22 +0000 (6 17:24 +0100)
tree6a9778b60835d3f49535d634dc753a1c173f4c78
parentfa21e6faa6f1d7de49fd030ebdb0722b59cf9a41
block: Give always priority to unused entries in the qcow2 L2 cache

The current algorithm to replace entries from the L2 cache gives
priority to newer hits by dividing the hit count of all existing
entries by two everytime there is a cache miss.

However, if there are several cache misses the hit count of the
existing entries can easily go down to 0. This will result in those
entries being replaced even when there are others that have never been
used.

This problem is more noticeable with larger disk images and cache
sizes, since the chances of having several misses before the cache is
full are higher.

If we make sure that the hit count can never go down to 0 again,
unused entries will always have priority.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qcow2-cache.c