| commit | 8c42dbe3956ac3eb8b1db18b941867936ce54b08 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 17 Oct 2018 08:26:38 +0000 (17 10:26 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 19 Oct 2018 12:51:34 +0000 (19 14:51 +0200) | ||
| tree | cad661971d009531e685ca9e8ab7a92331bd0368 | treesnapshot (tar.gz zip) |
| parent | 007e5f8782673d8e476398baaa5b4813741e970b | commitdiff |
net/socket: Fix invalid socket type error handling
Calling error_report() in a function that takes an Error ** argument
is suspicious. net_socket_fd_init() does that, and then fails without
setting an error. Wrong. I didn't analyze how exactly this can
break. A caller that reports the error on failure would crash.
Broken when commit c37f0bb1d0d (v2.11.0) converted the function to
Error. Fix by calling error_setg() instead of error_report().
Fixes: c37f0bb1d0d24e3a6b5f4659bb305913dcb798a6
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181017082702.5581-15-armbru@redhat.com>
Calling error_report() in a function that takes an Error ** argument
is suspicious. net_socket_fd_init() does that, and then fails without
setting an error. Wrong. I didn't analyze how exactly this can
break. A caller that reports the error on failure would crash.
Broken when commit c37f0bb1d0d (v2.11.0) converted the function to
Error. Fix by calling error_setg() instead of error_report().
Fixes: c37f0bb1d0d24e3a6b5f4659bb305913dcb798a6
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181017082702.5581-15-armbru@redhat.com>
| net/socket.c | diffblobblamehistory |