| commit | 8b81253332b5a3f3c67b6462f39caef47a00dd29 | |
| author | Alex Bennée <alex.bennee@linaro.org> | |
| Thu, 21 Sep 2017 11:06:25 +0000 (21 12:06 +0100) | ||
| committer | Richard Henderson <richard.henderson@linaro.org> | |
| Mon, 25 Sep 2017 18:23:30 +0000 (25 11:23 -0700) | ||
| tree | 829033e038f0bb155a9afc7f7a2fc1293c02d0a2 | treesnapshot (tar.gz zip) |
| parent | 460b6c8e581aa06b86f59eebd9e52edfe7adf417 | commitdiff |
accel/tcg/cputlb: avoid recursive BQL (fixes #1706296)
The mmio path (see exec.c:prepare_mmio_access) already protects itself
against recursive locking and it makes sense to do the same for
io_readx/writex. Otherwise any helper running in the BQL context will
assert when it attempts to write to device memory as in the case of
the bug report.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
CC: Richard Jones <rjones@redhat.com>
CC: Paolo Bonzini <bonzini@gnu.org>
CC: qemu-stable@nongnu.org
Message-Id: <20170921110625.9500-1-alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
The mmio path (see exec.c:prepare_mmio_access) already protects itself
against recursive locking and it makes sense to do the same for
io_readx/writex. Otherwise any helper running in the BQL context will
assert when it attempts to write to device memory as in the case of
the bug report.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
CC: Richard Jones <rjones@redhat.com>
CC: Paolo Bonzini <bonzini@gnu.org>
CC: qemu-stable@nongnu.org
Message-Id: <20170921110625.9500-1-alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| accel/tcg/cputlb.c | diffblobblamehistory |