docker: Don't enable networking as a side-effect of DEBUG=1
commit8a2390a4f4743f700da1d07c3bc04d6661ce1487
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 13 Jul 2017 14:43:52 +0000 (13 15:43 +0100)
committerFam Zheng <famz@redhat.com>
Mon, 17 Jul 2017 03:34:20 +0000 (17 11:34 +0800)
treece05f327b49b131397e4abfb2d07f5fe25333434
parent5aca18a4ff7950ac9f57cafd62476a626d713452
docker: Don't enable networking as a side-effect of DEBUG=1

When trying to debug problems with tests it is natural to set
DEBUG=1 when starting the docker environment. Unfortunately
this has a side-effect of enabling an eth0 network interface
in the container, which changes the operating environment of
the test suite. IOW tests with fail may suddenly start
working again if DEBUG=1 is set, due to changed network setup.

Add a separate NETWORK variable to allow enablement of
networking separately from DEBUG=1. This can be used in two
ways. To enable the default docker network backend

  make docker-test-build@fedora NETWORK=1

while to enable a specific network backend, eg join the network
associated with the container 'wibble':

  make docker-test-build@fedora NETWORK=container:wibble

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <20170713144352.2212-1-berrange@redhat.com>
[Drop the superfluous second $(subst ...). - Fam]
Signed-off-by: Fam Zheng <famz@redhat.com>
tests/docker/Makefile.include