qapi: Generate simpler marshalling code when no arguments
commit89bf68f933393a1bc0de4d07b59ffa8920da130f
authorMarkus Armbruster <armbru@redhat.com>
Fri, 24 Apr 2020 08:43:38 +0000 (24 10:43 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 30 Apr 2020 05:26:41 +0000 (30 07:26 +0200)
tree16990310cada8c9e2f6015c37769cf7223a1a01e
parent2061487bdba7fb9077efc09210224b42fad7d18f
qapi: Generate simpler marshalling code when no arguments

When command FOO has no arguments, its generated qmp_marshal_FOO() is
a bit confusing.  Make it simpler:

     visit_start_struct(v, NULL, NULL, 0, &err);
     if (err) {
         goto out;
     }
-
-    if (!err) {
-        visit_check_struct(v, &err);
-    }
+    visit_check_struct(v, &err);
     visit_end_struct(v, NULL);
     if (err) {
         goto out;
     }

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200424084338.26803-16-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
scripts/qapi/commands.py