qtest: do not return freed argument vector from qtest_rsp
commit88a8b27e556f5cb49a19d4c98a96590f61b74ed2
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 20 Nov 2020 07:31:49 +0000 (20 08:31 +0100)
committerThomas Huth <thuth@redhat.com>
Fri, 20 Nov 2020 14:04:16 +0000 (20 15:04 +0100)
tree09cd6582660f7fbdd56895392c161a8397f53058
parent7aed584ca6a11b6c8e673f3a8ba56c927d076440
qtest: do not return freed argument vector from qtest_rsp

If expected_args is 0, qtest frees the argument vector and then returns it
nevertheless.  Coverity complains; in practice this is not an issue because
expected_args == 0 means that the caller is not interested in the argument
vector, but it would be a potential problem if somebody wanted to add
commands with optional arguments to qtest.

Suggested-by: Kamil Dudka <kdudka@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20201120073149.99079-1-pbonzini@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/qtest/libqtest.c