scsi: move lsi53c8xx_create() callers to lsi53c8xx_handle_legacy_cmdline()
commit877eb21d5607e5097b8331e7a5b3d9714c0c5b91
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Wed, 19 Sep 2018 17:20:58 +0000 (19 18:20 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Tue, 25 Sep 2018 01:12:25 +0000 (25 11:12 +1000)
treef3b5b2dbe64b5ad7520af931b6a6ae54510f634d
parentf74a4f3a59b6168b8f3e84e4276c47eda610891d
scsi: move lsi53c8xx_create() callers to lsi53c8xx_handle_legacy_cmdline()

As part of commits a64aa5785d "hw: Deprecate -drive if=scsi with non-onboard
HBAs" and b891538e81 "hw/ppc/prep: Fix implicit creation of "-drive if=scsi"
devices" the lsi53c895a_create() and lsi53c810_create() functions were added
to wrap pci_create_simple() and scsi_bus_legacy_handle_cmdline().

Unfortunately this prevents us from changing qdev properties on the device
and/or changing the PCI configuration. By switching over to using the new
lsi53c8xx_handle_legacy_cmdline() function then the caller can now configure
and realize the LSI SCSI device exactly as required.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Peter Maydell <peter.maydell@linaro.org> [arm parts]
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/arm/realview.c
hw/arm/versatilepb.c
hw/hppa/machine.c
hw/ppc/prep.c