| commit | 81e0ab48dda611e9571dc2e166840205a4208567 | |
| author | Paolo Bonzini <pbonzini@redhat.com> | |
| Thu, 1 Oct 2015 08:59:51 +0000 (1 10:59 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 9 Oct 2015 13:25:56 +0000 (9 15:25 +0200) | ||
| tree | 9d061d1adabcf6b32802be14630c38e59a818f21 | treesnapshot (tar.gz zip) |
| parent | 2e2b8eb70fdb7dfbec39f3a19b20f9a73f2f813e | commitdiff |
hw: do not pass NULL to memory_region_init from instance_init
This causes the region to outlive the object, because it attaches the
region to /machine. This is not nice for the "realize" method, but
much worse for "instance_init" because it can cause dangling pointers
after a simple object_new/object_unref pair.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1443689999-12182-3-git-send-email-armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
This causes the region to outlive the object, because it attaches the
region to /machine. This is not nice for the "realize" method, but
much worse for "instance_init" because it can cause dangling pointers
after a simple object_new/object_unref pair.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1443689999-12182-3-git-send-email-armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>