block/null: Remove 'filename' option
commit809eb70ed6cfbfb6c198a25aed036849cc11944d
authorKevin Wolf <kwolf@redhat.com>
Fri, 4 Aug 2017 10:44:22 +0000 (4 12:44 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 8 Aug 2017 13:19:16 +0000 (8 15:19 +0200)
tree0bbb77953f6c7665588c637e55f51e2b3f2d5bcf
parent82346685b8cc0537819a3cf7fe2303b55b5f825f
block/null: Remove 'filename' option

This option was only added to allow 'null-co://' and 'null-aio://' as
filenames, its value never served any actual purpose and was ignored.
Nevertheless it was accepted as '-drive driver=null,filename=foo'.

The correct way to enable the protocol prefixes (and that without adding
a useless -drive option) is implementing .bdrv_parse_filename. This is
what this patch does.

Technically, this is an incompatible change, but the null block driver
is only used for benchmarking, testing and debugging, and an option
without effect isn't likely to be used by anyone anyway, so no bad
effects are to be expected.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
block/null.c
tests/qemu-iotests/136