| commit | 7b3dc2f8c0b817bbe78ba347130b3c99fe2c4470 | |
| author | Juan Quintela <quintela@redhat.com> | |
| Wed, 18 Nov 2020 08:37:34 +0000 (18 09:37 +0100) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Tue, 8 Dec 2020 18:48:57 +0000 (8 13:48 -0500) | ||
| tree | 145929d443a52e994f4744cc9942d59ceec13407 | treesnapshot (tar.gz zip) |
| parent | 9673a88e97d1eb428872bd261dbf56a0f3c2fd71 | commitdiff |
failover: Remove memory leak
Two things, at this point:
* n->primary_device_id has to be set, otherwise
virtio_net_find_primary don't work. So we have a leak here.
* it has to be exactly the same that prim_dev->id because what
qdev_find_recursive() does is just compare this two values.
So remove the unneeded assignment and leaky bits.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20201118083748.1328-14-quintela@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Two things, at this point:
* n->primary_device_id has to be set, otherwise
virtio_net_find_primary don't work. So we have a leak here.
* it has to be exactly the same that prim_dev->id because what
qdev_find_recursive() does is just compare this two values.
So remove the unneeded assignment and leaky bits.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20201118083748.1328-14-quintela@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| hw/net/virtio-net.c | diffblobblamehistory |