| commit | 7aab5899764887f6b0512cb2e5c11bdc2a5d3644 | |
| author | David Gibson <david@gibson.dropbear.id.au> | |
| Thu, 26 Mar 2020 05:12:40 +0000 (26 16:12 +1100) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Mon, 6 Apr 2020 22:55:11 +0000 (7 08:55 +1000) | ||
| tree | 038ea431a4fb40ac5eb7b769d15914d891a1a8ce | treesnapshot (tar.gz zip) |
| parent | 4f7a11f93fcb970bdcd2faa12337f4d1269b45f4 | commitdiff |
spapr: Fix failure path for attempting to hot unplug PCI bridges
For various technical reasons we can't currently allow unplug a PCI to PCI
bridge on the pseries machine. spapr_pci_unplug_request() correctly
generates an error message if that's attempted.
But.. if the given errp is not error_abort or error_fatal, it doesn't
actually stop trying to unplug the bridge anyway.
Fixes: 14e714900f6b "spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges"
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
For various technical reasons we can't currently allow unplug a PCI to PCI
bridge on the pseries machine. spapr_pci_unplug_request() correctly
generates an error message if that's attempted.
But.. if the given errp is not error_abort or error_fatal, it doesn't
actually stop trying to unplug the bridge anyway.
Fixes: 14e714900f6b "spapr: Allow hot plug/unplug of PCI bridges and devices under PCI bridges"
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
| hw/ppc/spapr_pci.c | diffblobblamehistory |