openpic: avoid buffer overrun on incoming migration
commit73d963c0a75cb99c6aaa3f6f25e427aa0b35a02e
authorMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 28 Apr 2014 13:08:17 +0000 (28 16:08 +0300)
committerJuan Quintela <quintela@redhat.com>
Mon, 5 May 2014 20:15:03 +0000 (5 22:15 +0200)
tree17b297d84df619eaf0362531c707bde6e1b45287
parenta9c380db3b8c6af19546a68145c8d1438a09c92b
openpic: avoid buffer overrun on incoming migration

CVE-2013-4534

opp->nb_cpus is read from the wire and used to determine how many
IRQDest elements to read into opp->dst[]. If the value exceeds the
length of opp->dst[], MAX_CPU, opp->dst[] can be overrun with arbitrary
data from the wire.

Fix this by failing migration if the value read from the wire exceeds
MAX_CPU.

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
hw/intc/openpic.c