| commit | 70fc9cb0920fce3c2c0a090e69bf06d39f4b2362 | |
| author | Daniel Henrique Barboza <danielhb413@gmail.com> | |
| Mon, 13 Apr 2020 20:36:28 +0000 (13 17:36 -0300) | ||
| committer | David Gibson <david@gibson.dropbear.id.au> | |
| Thu, 7 May 2020 01:10:50 +0000 (7 11:10 +1000) | ||
| tree | 1036957b57378f567fe5592f39d2cc4f174b6658 | treesnapshot (tar.gz zip) |
| parent | d04ea940c597201a6610c5d1712809ed35dd77ec | commitdiff |
spapr_nvdimm.c: make 'label-size' mandatory
The pseries machine does not support NVDIMM modules without label.
Attempting to do so, even if the overall block size is aligned with
256MB, will seg fault the guest kernel during NVDIMM probe. This
can be avoided by forcing 'label-size' to always be present for
sPAPR NVDIMMs.
The verification was put before the alignment check because the
presence of label-size affects the alignment calculation, so
it's not optimal to warn the user about an alignment error,
then about the lack of label-size, then about a new alignment
error when the user sets a label-size.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200413203628.31636-1-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
The pseries machine does not support NVDIMM modules without label.
Attempting to do so, even if the overall block size is aligned with
256MB, will seg fault the guest kernel during NVDIMM probe. This
can be avoided by forcing 'label-size' to always be present for
sPAPR NVDIMMs.
The verification was put before the alignment check because the
presence of label-size affects the alignment calculation, so
it's not optimal to warn the user about an alignment error,
then about the lack of label-size, then about a new alignment
error when the user sets a label-size.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200413203628.31636-1-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| hw/ppc/spapr_nvdimm.c | diffblobblamehistory |