| commit | 6c615ec57e83bf8cc7b1721bcd58c7d1ed93ef65 | |
| author | Michael Roth <mdroth@linux.vnet.ibm.com> | |
| Mon, 14 May 2012 21:42:35 +0000 (14 16:42 -0500) | ||
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | |
| Tue, 15 May 2012 14:16:55 +0000 (15 09:16 -0500) | ||
| tree | 7f3984ee87168ce88de2c66b330c5bdd639febef | treesnapshot (tar.gz zip) |
| parent | 3674838cd05268954bb6473239cd7f700a79bf0f | commitdiff |
qemu-ga: fix segv after failure to open log file
Currently, if we fail to open the specified log file (generally due to a
permissions issue), we'll assign NULL to the logfile handle (stderr,
initially) used by the logging routines, which can cause a segfault to
occur when we attempt to report the error before exiting.
Instead, only re-assign if the open() was successful.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Currently, if we fail to open the specified log file (generally due to a
permissions issue), we'll assign NULL to the logfile handle (stderr,
initially) used by the logging routines, which can cause a segfault to
occur when we attempt to report the error before exiting.
Instead, only re-assign if the open() was successful.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
| qemu-ga.c | diffblobblamehistory |