| commit | 6c1ddc36d8ddcb21e905dfdecfb9f2e4d4fd8acc | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 15 May 2020 04:22:31 +0000 (15 06:22 +0200) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Wed, 10 Jun 2020 16:09:59 +0000 (10 12:09 -0400) | ||
| tree | 9545b5fd5b539883f8fa6c3ff392f94fd3288bdd | treesnapshot (tar.gz zip) |
| parent | c5e18709585c6f2a3464f89434b0040ce5164d9d | commitdiff |
cpus: Fix botched configure_icount() error API violation fix
Before recent commit abc9bf69a66, configure_icount() returned early
when option "shift" was absent: succeed when option "align" was also
absent, else fail.
Since then, it still errors out when only "align" is present, but
continues when both are absent. Crashes when examining the value of
"shift" further. Reproducer: -icount "".
Revert this erroneous part of the commit.
Fixes: abc9bf69a66a11499a801ff545b8fe7adbb3a04c
Fixes: Coverity CID 1428754
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200515042231.18201-1-armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Before recent commit abc9bf69a66, configure_icount() returned early
when option "shift" was absent: succeed when option "align" was also
absent, else fail.
Since then, it still errors out when only "align" is present, but
continues when both are absent. Crashes when examining the value of
"shift" further. Reproducer: -icount "".
Revert this erroneous part of the commit.
Fixes: abc9bf69a66a11499a801ff545b8fe7adbb3a04c
Fixes: Coverity CID 1428754
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200515042231.18201-1-armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| cpus.c | diffblobblamehistory |