migration: handle CANCELLING state in migration_completion()
commit6ba11211bd616237d028fb5d27f8576fc8cf7b1c
authorLongpeng(Mike) <longpeng2@huawei.com>
Thu, 5 Nov 2020 09:17:26 +0000 (5 17:17 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Thu, 12 Nov 2020 15:52:20 +0000 (12 15:52 +0000)
tree2796e5b696d91cae0453ea2065d25be655e55684
parent9e8424088c5648959e4c5d715290e6cfa96df087
migration: handle CANCELLING state in migration_completion()

The following sequence may cause the VM abort during migration:

1. RUN_STATE_RUNNING,MIGRATION_STATUS_ACTIVE

2. before call migration_completion(), we send migrate_cancel
   QMP command, the state machine is changed to:
     RUN_STATE_RUNNING,MIGRATION_STATUS_CANCELLING

3. call migration_completion(), and the state machine is
   switch to: RUN_STATE_RUNNING,MIGRATION_STATUS_COMPLETED

4. call migration_iteration_finish(), because the migration
   status is COMPLETED, so it will try to set the runstate
   to POSTMIGRATE, but RUNNING-->POSTMIGRATE is an invalid
   transition, so abort().

The migration_completion() should not change the migration state
to COMPLETED if it is already changed to CANCELLING.

Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
Message-Id: <20201105091726.148-1-longpeng2@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/migration.c