block/ssh: Do not report read/write/flush errors to the user
commit6b3048cee0e0eccd27b62954ecc57c4a1bceb976
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Apr 2019 19:06:28 +0000 (17 21:06 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 17 Apr 2019 19:21:49 +0000 (17 21:21 +0200)
tree17dcc0ef5b02a1dffe52709bb891400fd05570a4
parente9e1d92d1d8f0bce81a1f25cfeeda9c7374b6ab5
block/ssh: Do not report read/write/flush errors to the user

Callbacks ssh_co_readv(), ssh_co_writev(), ssh_co_flush() report
errors to the user with error_printf().  They shouldn't, it's their
caller's job.  Replace by a suitable trace point.  While there, drop
the unreachable !s->sftp case.

Perhaps we should convert this part of the block driver interface to
Error, so block drivers can pass more detail to their callers.  Not
today.

Cc: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190417190641.26814-3-armbru@redhat.com>
block/ssh.c
block/trace-events