pc: make sure that plugged CPUs are of the same type
commit6970c5ff13a47df7ce41b901a4459c587a03d16b
authorIgor Mammedov <imammedo@redhat.com>
Tue, 10 Oct 2017 12:34:39 +0000 (10 14:34 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 12 Oct 2017 10:10:38 +0000 (12 12:10 +0200)
tree947a2d6b7402339778603fff67c534148c21f480
parentb021d1c04452276f4926eed2d104ccbd1037a6e1
pc: make sure that plugged CPUs are of the same type

heterogeneous cpus are not supported and hotplugging different
cpu model crashes QEMU:

  qemu-system-x86_64 -cpu qemu64 -smp 1,maxcpus=2
  (qemu) device_add host-x86_64-cpu,socket-id=1,core-id=0,thread-id=0,id=foo
  (qemu) info cpus
  error: failed to get MSR 0x38d
  qemu-system-x86_64: target/i386/kvm.c:2121: kvm_get_msrs: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed.
  Aborted (core dumped)

Gracefully fail hotplug process in case of user mistake.

Reported-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1507638879-200718-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/i386/pc.c