| commit | 670777a91580ec7e34d879c3973927f748be6f47 | |
| author | Kővágó, Zoltán <dirty.ice.hu@gmail.com> | |
| Sun, 13 Oct 2019 19:58:06 +0000 (13 21:58 +0200) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Fri, 18 Oct 2019 06:14:05 +0000 (18 08:14 +0200) | ||
| tree | ee9d5c57f38fe689da268b2a1b9712225672e693 | treesnapshot (tar.gz zip) |
| parent | 3e44607e9394ca08f8672bffa045d2462a371bbc | commitdiff |
usbaudio: change playback counters to 64 bit
With stereo playback, they need about 375 minutes of continuous audio
playback to overflow, which is usually not a problem (as stopping and
later resuming playback resets the counters). But with 7.1 audio, they
only need about 95 minutes to overflow.
After the overflow, the buf->prod % USBAUDIO_PACKET_SIZE(channels)
assertion no longer holds true, which will result in overflowing the
buffer. With 64 bit variables, it would take about 762000 years to
overflow.
Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Message-id: ff866985ed369f1e18ea7c70da6a7fce8e241deb.1570996490.git.DirtY.iCE.hu@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
With stereo playback, they need about 375 minutes of continuous audio
playback to overflow, which is usually not a problem (as stopping and
later resuming playback resets the counters). But with 7.1 audio, they
only need about 95 minutes to overflow.
After the overflow, the buf->prod % USBAUDIO_PACKET_SIZE(channels)
assertion no longer holds true, which will result in overflowing the
buffer. With 64 bit variables, it would take about 762000 years to
overflow.
Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Message-id: ff866985ed369f1e18ea7c70da6a7fce8e241deb.1570996490.git.DirtY.iCE.hu@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| hw/usb/dev-audio.c | diffblobblamehistory |