| commit | 66f092d25697e11847b61d761c38ddebedaed8d1 | |
| author | Hans de Goede <hdegoede@redhat.com> | |
| Wed, 29 Aug 2012 08:12:52 +0000 (29 10:12 +0200) | ||
| committer | Gerd Hoffmann <kraxel@redhat.com> | |
| Tue, 11 Sep 2012 05:42:59 +0000 (11 07:42 +0200) | ||
| tree | 9b9c87f0ea8945e2bb1fcbf5e62ce2b60aff4099 | treesnapshot (tar.gz zip) |
| parent | 9c1f67654ab611553bbfca54a1e0922728c25760 | commitdiff |
Revert "ehci: don't flush cache on doorbell rings."
This reverts commit 9bc3a3a216e2689bfcdd36c3e079333bbdbf3ba0, which got
added to fix an issue where the real, underlying cause was not stopping
the ep queue on an error.
Now that the underlying cause is fixed by the "usb: Halt ep queue and
cancel pending packets on a packet error" patch, the "don't flush" fix
is no longer needed.
Not only is it not needed, it causes us to see cancellations (unlinks)
done by the Linux EHCI driver too late, which in combination with the new
usb-core packet-id generation where qtd addresses are used as ids, causes
duplicate ids for in flight packets.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This reverts commit 9bc3a3a216e2689bfcdd36c3e079333bbdbf3ba0, which got
added to fix an issue where the real, underlying cause was not stopping
the ep queue on an error.
Now that the underlying cause is fixed by the "usb: Halt ep queue and
cancel pending packets on a packet error" patch, the "don't flush" fix
is no longer needed.
Not only is it not needed, it causes us to see cancellations (unlinks)
done by the Linux EHCI driver too late, which in combination with the new
usb-core packet-id generation where qtd addresses are used as ids, causes
duplicate ids for in flight packets.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| hw/usb/hcd-ehci.c | diffblobblamehistory |