| commit | 64af7a8bad2cbda178730a842fa0d43d02415dbc | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Tue, 7 Jul 2020 16:05:40 +0000 (7 18:05 +0200) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Fri, 10 Jul 2020 13:01:06 +0000 (10 15:01 +0200) | ||
| tree | b9a6312d082c325cd1d1d0b1d719249076efec60 | treesnapshot (tar.gz zip) |
| parent | 81a8a0726a67b0f28d36201c1b9e0944e5849a76 | commitdiff |
qemu-option: Replace opt_set() by cleaner opt_validate()
opt_set() frees its argument @value on failure. Slightly unclean;
functions ideally do nothing on failure.
To tidy this up, move opt_create() from opt_set() into its callers,
along with the cleanup. Rename opt_set() to opt_validate(), noting
its similarity to qemu_opts_validate(). Drop redundant parameter
@opts; use opt->opts instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-13-armbru@redhat.com>
opt_set() frees its argument @value on failure. Slightly unclean;
functions ideally do nothing on failure.
To tidy this up, move opt_create() from opt_set() into its callers,
along with the cleanup. Rename opt_set() to opt_validate(), noting
its similarity to qemu_opts_validate(). Drop redundant parameter
@opts; use opt->opts instead.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-13-armbru@redhat.com>
| util/qemu-option.c | diffblobblamehistory |