target/arm: Set FSR for BKPT, BRK when raising exception
commit62b94f31d0df75187bb00684fc29e8639eacc0c5
authorPeter Maydell <peter.maydell@linaro.org>
Fri, 23 Mar 2018 18:26:46 +0000 (23 18:26 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 23 Mar 2018 18:26:46 +0000 (23 18:26 +0000)
tree1a8485426cbf1c4f8b7adb9308feaf89635c59fc
parent81621d9ab8a0f07956e67850b15eebf6d6992eec
target/arm: Set FSR for BKPT, BRK when raising exception

Now that we have a helper function specifically for the BRK and
BKPT instructions, we can set the exception.fsr there rather
than in arm_cpu_do_interrupt_aarch32(). This allows us to
use our new arm_debug_exception_fsr() helper.

In particular this fixes a bug where we were hardcoding the
short-form IFSR value, which is wrong if the target exception
level has LPAE enabled.

Fixes: https://bugs.launchpad.net/qemu/+bug/1756927
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180320134114.30418-4-peter.maydell@linaro.org
target/arm/helper.c
target/arm/op_helper.c