qapi: Use returned bool to check for failure, Coccinelle part
commit62a35aaa310807fa161ca041ddb0f308faeb582b
authorMarkus Armbruster <armbru@redhat.com>
Tue, 7 Jul 2020 16:05:46 +0000 (7 18:05 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 10 Jul 2020 13:18:08 +0000 (10 15:18 +0200)
treeedd58456e5462b42facf9f7317ac253df19fe369
parent012d4c96e260f99d5ca95cd033274af4fb73b825
qapi: Use returned bool to check for failure, Coccinelle part

The previous commit enables conversion of

    visit_foo(..., &err);
    if (err) {
        ...
    }

to

    if (!visit_foo(..., errp)) {
        ...
    }

for visitor functions that now return true / false on success / error.
Coccinelle script:

    @@
    identifier fun =~ "check_list|input_type_enum|lv_start_struct|lv_type_bool|lv_type_int64|lv_type_str|lv_type_uint64|output_type_enum|parse_type_bool|parse_type_int64|parse_type_null|parse_type_number|parse_type_size|parse_type_str|parse_type_uint64|print_type_bool|print_type_int64|print_type_null|print_type_number|print_type_size|print_type_str|print_type_uint64|qapi_clone_start_alternate|qapi_clone_start_list|qapi_clone_start_struct|qapi_clone_type_bool|qapi_clone_type_int64|qapi_clone_type_null|qapi_clone_type_number|qapi_clone_type_str|qapi_clone_type_uint64|qapi_dealloc_start_list|qapi_dealloc_start_struct|qapi_dealloc_type_anything|qapi_dealloc_type_bool|qapi_dealloc_type_int64|qapi_dealloc_type_null|qapi_dealloc_type_number|qapi_dealloc_type_str|qapi_dealloc_type_uint64|qobject_input_check_list|qobject_input_check_struct|qobject_input_start_alternate|qobject_input_start_list|qobject_input_start_struct|qobject_input_type_any|qobject_input_type_bool|qobject_input_type_bool_keyval|qobject_input_type_int64|qobject_input_type_int64_keyval|qobject_input_type_null|qobject_input_type_number|qobject_input_type_number_keyval|qobject_input_type_size_keyval|qobject_input_type_str|qobject_input_type_str_keyval|qobject_input_type_uint64|qobject_input_type_uint64_keyval|qobject_output_start_list|qobject_output_start_struct|qobject_output_type_any|qobject_output_type_bool|qobject_output_type_int64|qobject_output_type_null|qobject_output_type_number|qobject_output_type_str|qobject_output_type_uint64|start_list|visit_check_list|visit_check_struct|visit_start_alternate|visit_start_list|visit_start_struct|visit_type_.*";
    expression list args;
    typedef Error;
    Error *err;
    @@
    -    fun(args, &err);
    -    if (err)
    +    if (!fun(args, &err))
         {
             ...
         }

A few line breaks tidied up manually.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-19-armbru@redhat.com>
46 files changed:
accel/kvm/kvm-all.c
accel/tcg/tcg-all.c
backends/cryptodev.c
backends/hostmem-file.c
backends/hostmem-memfd.c
backends/hostmem.c
backends/tpm/tpm_util.c
block/blkdebug.c
block/nbd.c
block/sheepdog.c
block/throttle-groups.c
bootdevice.c
hw/block/xen-block.c
hw/core/machine.c
hw/core/qdev-properties-system.c
hw/core/qdev-properties.c
hw/cpu/core.c
hw/gpio/aspeed_gpio.c
hw/i386/pc.c
hw/ide/qdev.c
hw/intc/apic_common.c
hw/mem/nvdimm.c
hw/misc/aspeed_sdmc.c
hw/misc/pca9552.c
hw/misc/tmp105.c
hw/misc/tmp421.c
hw/net/ne2000-isa.c
hw/ppc/spapr_caps.c
hw/ppc/spapr_drc.c
hw/s390x/css.c
hw/usb/dev-storage.c
hw/vfio/pci-quirks.c
hw/virtio/virtio-balloon.c
iothread.c
monitor/hmp-cmds.c
net/colo-compare.c
net/dump.c
net/filter-buffer.c
qom/object.c
qom/object_interfaces.c
target/arm/cpu64.c
target/arm/monitor.c
target/i386/cpu.c
target/ppc/compat.c
target/s390x/cpu_models.c
target/sparc/cpu.c